Factor out Namespace Manager #826
Merged
+486
−324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
peterbroadhurst,
nguyer and
nickgaski
as code owners
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 297 299 +2
Lines 19095 19108 +13
=========================================
+ Hits 19095 19108 +13
Continue to review full report at Codecov.
|
awrichar
force-pushed
the
namespacemgr
branch
2 times, most recently
from
221bd71 to
dcc06d1
Compare
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
nguyer
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hyperledger/firefly-fir#12
In a chain with #821This just creates a new Namespace Manager component to factor namespace-related code out of Orchestrator. Going forward, this component will take more responsibility for determining which plugins to use for each namespace, and other components will consult it dynamically instead of retaining their own list of plugins.